Feature: Support colon character in event namespaces

[SuperPat45]

Description

I have an issue for unbind an event created for a component having a colon character in its id.
The colon character is used as separator by the JSF API.

The event is bind like this:

var elementId = document.getElementById('test:colon').id.replace(':', '\\:'),
selector = '#' + elementId + ' .clickMe';
$(document).on('click.xxx-' + elementId, selector, function (){alert('clicked');});

But the off function does not unbing the event:
$(document).off('click.xxx-' + elementId, selector);

The issue appear in the off function on the line:
( !tmp || tmp.test( handleObj.namespace ) )
The regex pattern failed to test the expression because of the escape character...
If you change the line:
tmp = tmp[ 2 ] && new RegExp( "(^|\\.)" + namespaces.join( "\\.(?:.*\\.|)" ) + "(\\.|$)" );
by escaping the \ character:
tmp = tmp[ 2 ] && new RegExp( "(^|\\.)" + namespaces.join( "\\.(?:.*\\.|)" ).replace('\\', '\\\\') + "(\\.|$)" );
seem to works in the chrome debugger:

• What do you expect to happen?
  Event must be unbind
• What actually happens?
  Event is not unbind
• Which browsers are affected?
  All browsers

Link to test case

https://jsbin.com/yamitatece/edit?html,js,output

[mgol]

Thanks for the report.

The ID of the element doesn't matter, the issue is caused by the namespace not working well with special chars; see the test case:
https://jsbin.com/zukecaf/1/edit?html,js,output

The problem lies in this line:
https://github.com/jquery/jquery/blob/3.3.1/src/event.js#L254

which constructs a RegExp from namespaces without escaping special characters. I wasn't sure if we support non-alphanumeric namespaces but the docs don't mention any restrictions on them.

Unfortunately, there is no generic RegExp escape function.

[mgol]

Some discussions about the rejected RegExp.escape proposal:

https://esdiscuss.org/topic/regexp-escape
tc39/proposal-regex-escaping#37

[dmethvin]

See https://bugs.jquery.com/ticket/11458 .

I would still prefer to keep namespaces alphanumeric rather than allowing anything other than a period or space which already have their meanings.

[timmywil]

Per meeting, we'll keep namespaces strictly alphanumeric and document. Strip out the colon character from your selector when constructing namespaces and all should be well.