-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.css("--custom") throws TypeError: ret is undefined (3.6.0 → 3.6.1 regression) #5105
Comments
jQuery is held at 3.6.0 due to jquery/jquery#5105. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Fixes jquerygh-5105 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Fixes jquerygh-5105 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
jQuery is held at 3.6.0 due to jquery/jquery#5105. Signed-off-by: Anders Kaseorg <anders@zulip.com>
jQuery is held at 3.6.0 due to jquery/jquery#5105. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Thanks for the report. That said, I'm not sure the That said, for regular unknown properties that is the logic we are using. I guess we should discuss what's our goal here. |
Yeah, jQuery has given |
I agree with that but there’s also a case with a custom property set to an empty string or a whitespace-only string. IMO then we should return an empty string, not undefined. I’ll need to check if this is possible with the Web APIs we have. |
jQuery is held at 3.6.0 due to jquery/jquery#5105. Signed-off-by: Anders Kaseorg <anders@zulip.com>
jQuery is held at 3.6.0 due to jquery/jquery#5105. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Fixes jquerygh-5105 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Fixes jquerygh-5105 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Fixes jquerygh-5105 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Fixes jquerygh-5105 Closes jquerygh-5106 Signed-off-by: Anders Kaseorg <andersk@mit.edu> (cherry picked from commit ed306c0)
Description
In jQuery 3.6.0,
$element.css("--custom")
correctly returnedundefined
for a custom property that isn’t set. But in jQuery 3.6.1, it crashes withTypeError: ret is undefined
.This breaks the Zulip settings dialog.
This was presumably introduced by #4930 (cc @fecore1 @mgol).
Link to test case
https://codepen.io/anderskaseorg/pen/rNvNZWW
The text was updated successfully, but these errors were encountered: