Effects Tests (compat) #2340
Merged
Effects Tests (compat) #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnarf
force-pushed
the
effects-tests-compat
branch
from
16ead78 to
5b986b5
Compare
Conflicts: src/selector-native.js test/index.html test/unit/effects.js
Closes jquerygh-2340 (cherry picked from commit b3b2d6c) Conflicts: src/effects.js
gnarf
force-pushed
the
effects-tests-compat
branch
from
5b986b5 to
0ff8057
Compare
The CSS value rounding error was causig failures on FF and IE.
|
@gnarf This broke effects tests in all browsers & a couple more in IE8: http://swarm.jquery.org/job/817. Tests for the Could you have a look? We try to keep our test results green. :) |
|
Ah, I've seen your IRC messages just now. I guess we'll handle it tomorrow. |
|
It was a one-line mistake in cherry-picking the Sinon stuff. ;) An extraordinary assignment Fixed in 29561bc. Note that IE8 still doesn't pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2326 but for the compat branch