compat - Update code style, partially use new qunit interface, give test module a new name #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attaching test divs to document.documentElement instead of document.body used to cause issues in jQuery 1.x; jQuery Compat doesn't execute any tests on document ready, though so it could be aligned with master. This makes jQuery Compat support tests work correctly even if jQuery is included & used in head before body even exists - making it similar to the master behavior. Fixes jquerygh-2502
Fixes jquerygh-2133 Fixes jquerygh-2501 Closes jquerygh-2504 Refs jquerygh-1950 Refs jquerygh-1949 Refs jquerygh-2397 Refs jquerygh-1537 Refs jquerygh-2504 Refs 842958e
http://qunitjs.com/upgrade-guide-2.x/ For most of the boring work was used https://github.com/apsdehal/qunit-migrate package However, it can't update local qunit helpers, plus in some places old QUnit.asyncTest signature is still used Fixes jquerygh-2540
markelog
force-pushed
the
build-compat
branch
from
6a6e90d
to
5fbb931
Compare
Yeah, it's hard to review such a big thing quickly and since it's an analogous of the |
👍 |
|
Landed via 3923bb8...cbb0be6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2542 to compat branch
Also incorporates #2504 and cherry-picks 63a577a. References to master commits will be added when pr to master will be landed.
ajax tests added selectively from master branch, should be all included, but it would be cool if someone would verify it.