Fixes #9441 isues with innreWidth and OuterWidth on child of a hidden parent #399
Conversation
| equals($divChild.width(), $divNormal.width(), "width() is wrong see #9441"); | ||
| equals($divChild.innerWidth(), $divNormal.innerWidth(), "innreWidth() is wrong see #9441"); | ||
| equals($divChild.outerWidth(), $divNormal.outerWidth(), "outerWidth() is wrong see #9441"); | ||
| equals($divChild.outerWidth(true), $divNormal.outerWidth(true), "outerWidth(true) is wrong see #9300"); |
There was a problem hiding this comment.
It's helpful when debugging to not have to go to the bug ticket. Please be more descriptive as to what these tests are doing. Also, tests should follow style guidelines as well. Thanks for the hard work!
…efs #9441 and #9300
|
Thanks for the help @timmywil. I've updated the test to match the regular styles. I had previously just used the style of the existing tests, so that's where I was thrown off. I added tests for height as well that now pass with my fix in place. |
|
@mikesherov I can understand the inclination to mimic the existing tests - we've only begun to really enforce the style guide on tests in the past few months, so it's a game of catch up now - thanks for your patience and for keeping up with the reviews |
|
Any movement on this? I have been working on another set of fixes that I'd like to work further on, but is based off of this change and the other pull request. I'd love to know I'm working on stable ground to finish those up. |
|
Landed. 0742056...75203de |
|
Hey, nice followup commit. One small thing: you left "var fellback = false" in there which is now unnecessary. Thanks again. |
|
Yep, noticed after I committed. :) |
This commit fixes issue #9441, but is dependent on my fix for #9300: #394 so it contains those commits as well.
I wanted to put this up here just in case you accept the #9300 fix, you won't need to wait for the #9441 fix.