-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Core: Use Array#flat where supported #4459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b042b7a
Add support to native `.flat()` function from array
aelafifi 67ca9b0
Add unit tests
aelafifi 78ae81b
Merge branch 'master' into support_native_array_flat
aelafifi 94ce632
Remove indent
aelafifi 6e4a28f
Add support comment
aelafifi 7cfd435
Update the comment phrase
507a15c
Core: use `flat` instead of `concat` for all occurrences
aelafifi ad5d01c
Modify support browser versions
aelafifi 039ce10
Hotfix: call `flat` directly without `.call`
aelafifi 2f7baf8
Core: remove hardcoded default value for Array#flat
aelafifi dea751a
Core: remove hardcoded default value for Array#flat
aelafifi d95cacf
Core: add guard for tests which requires Array#flat existence
aelafifi 5bf3b7a
Core: remove concat var file
aelafifi 6bf0abb
Core: add browser support comments for test guard
aelafifi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
define( [ | ||
"./arr", | ||
"./concat" | ||
], function( arr, concat ) { | ||
|
||
"use strict"; | ||
|
||
// Support: IE 11+, Edge 18+ | ||
// Provide fallback for browsers without Array#flat. | ||
return arr.flat ? function( array ) { | ||
return arr.flat.call( array ); | ||
} : function( array ) { | ||
return concat.apply( [], array ); | ||
}; | ||
|
||
} ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.