Build: Reference GitHub Actions by commit SHAs #5269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important to make sure the SHA's are from the original repositories and not forks. For reference: https://github.com/actions/checkout/releases/tag/v3.5.2 actions/checkout@8e5e7e5 https://github.com/github/codeql-action/releases/tag/v2.3.6 github/codeql-action@83f0fe6 Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
It's important to make sure the SHA's are from the original repositories and not forks. For reference: https://github.com/actions/checkout/releases/tag/v3.5.2 actions/checkout@8e5e7e5 https://github.com/actions/cache/releases/tag/v3.3.1 actions/cache@88522ab https://github.com/actions/setup-node/releases/tag/v3.6.0 actions/setup-node@64ed1c7 Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
|
Thank you! Please sign the CLA. |
|
@gabibguti Ping. Please sign the OpenJSF CLA, we cannot merge the PR otherwise. |
|
Hi @mgol! Thanks for the reminder. I'm checking internally with Google if I can sign the CLA. |
|
I see. If you're submitting this on company time, I think you'll need to chose the "Proceed as a Corporate Contributor" button. |
|
@mgol Done! |
mgol
changed the title
mgol
pushed a commit
that referenced
this pull request
Jun 13, 2023
The SHAs are verified to come from the original repositories and not forks. For reference: https://github.com/actions/checkout/releases/tag/v3.5.2 actions/checkout@8e5e7e5 https://github.com/actions/cache/releases/tag/v3.3.1 actions/cache@88522ab https://github.com/actions/setup-node/releases/tag/v3.6.0 actions/setup-node@64ed1c7 Fixes gh-5266 Closes gh-5269 Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> (cherry picked from commit 784b9ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #5266
It's important to make sure the SHA's are from the original repositories and not forks. I have manually verified all of them and added references in the commit descriptions.
Checklist