Skip to content

Conversation

mkristian
Copy link
Member

keep the default x509 certs and directories in line with MRI, only if
they do not exists fallback on cacerts from the java.home/lib/security/cacerts

fixes #49 and keeps the idea of b914091

Sponsored by Lookout Inc.

@mkristian
Copy link
Member Author

@kares @headius please have a look this.

@kares
Copy link
Member

kares commented Aug 10, 2015

makes sense - hopefully there won't be any drawbacks if there are any we can make a system-prop switch

@kares
Copy link
Member

kares commented Aug 10, 2015

on a second note (without looking) will we actually use X509_CERT_AREA if it points to OpenSSL's cert dir since the SSL engine will have those available from Java for sure (as reported in jruby/jruby#1953).

... cert lookup will honor these, although by default does nothing, right?

@mkristian
Copy link
Member Author

X509_CERT_AREA is not used but the X509_CERT_DIR and X509_CERT_FILE

actually b914091 made those two to be used.

still jruby/jruby#1953 says paths are different then on ubuntu. will look into this.

@mkristian
Copy link
Member Author

keep the default x509 certs and directories in line with MRI, only if
they do not exists fallback on cacerts from the java.home/lib/security/cacerts

fixes #49 and keeps the idea of b914091

Sponsored by Lookout Inc.
mkristian added a commit that referenced this pull request Aug 11, 2015
keep trusted certificate stores in line with MRI if possible
@mkristian mkristian merged commit d717926 into master Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certs + private keys location is not in line with MRI
2 participants