New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic smoke test with warbler no longer works with jruby-jars-9.2.10 #6083
Comments
This also seems likely to be tied to changes in RubyGems. We did some brief investigation of two failures (that we thought were minor and unlikely to affect anyone) when we upgrade to RubyGems 3.0.6, but apparently we were too optimistic. See #6060 for the information we have so far along with the tests that were disabled. |
We need to get this smoke test into our CI, which is currently Travis. Can you help? |
Dir.glob was treating any passed-in `base` path as a normal file path, which cause it to treat URIs as a relative path. The logic then proceeded to prepend the cwd to this URI, producing a nonsense path. This patch uses File.expand_path logic to acquire the base path, which keeps it a URI and allows the rest of glob to handle it as if the glob and base were expanded before calling Dir.glob. The change means that the two following Dir.glob calls work the same, fixing the issues discovered in jruby#6060. It will very likely also fix the issues reported in jruby#6082 and jruby#6083. Fixes jruby#6060 Fixes jruby#6082 Fixes jruby#6083
I have pushed a likely fix in #6084 that gets the tests from #6060 and the asciidoctor example from #6082 working. If you can that on Can you turn your smoke test into a complete repository, or a PR for JRuby's Travis CI? I'm not sure how to run it. |
Thanks for fixing this
I can try although I'm not too familiar with your CI. Where in the project heirarchy should I place the dummy test project? Is there another example of such a high level integration test? |
The test project is here. Running
inside that test project should trigger the issue. |
Also, this is the sample project as a separate repo that was provided to us when we added the scenario to our CI, in this bundler ticket. |
That's a good start for us, thank you. As an example, you can see how we test sequel in CI. Basically just clone it and run its tests. Smaller integration tests could go in our repo, or remain as a separate repo (possibly owned by jruby organization if it's not a standalone project). |
Environment Information
jruby-jars
gem version needs to be 9.2.10.0Expected Behavior
The test is this Github workflow:
https://github.com/rubygems/bundler/blob/c65280dd3f52b4b551bb3bb1ca6ab114d6a4af5c/.github/workflows/jruby.yml
which uses the following
Gemfile
where
demo
includes a only a dummy gemspec, andbin/warbler-example.rb
contains justputs require "bundler/setup"
.Pinning jruby-jars to
9.2.9.0
printstrue
as expected.Using
jruby-jars
9.2.10.0 instead crashes with the following error:Link to CI log: https://github.com/rubygems/bundler/runs/453791482.
I believe this is related to the rubygems upgrade made in jruby-9.2.10.0.
Let me know if this should be tracked/reported somewhere else like the
warbler
project, orrubygems
itself.Thanks!
The text was updated successfully, but these errors were encountered: