New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby-2.5] Implement String#delete_suffix #5055

Merged
merged 3 commits into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@ChrisBr
Contributor

ChrisBr commented Feb 19, 2018

ChrisBr added some commits Feb 19, 2018

Implement String#delete_suffix & String#delete_suffix!
also refactored the delete_prefix functions.
Implement tests for String#delete_suffix
c&p from 510957df33be322875e7d863b9af6934f2574779
@headius

This comment has been minimized.

Member

headius commented Feb 20, 2018

I assume the tests just come from MRI? I can update the tests on ruby-2.5 to match Ruby 2.5.0's tests...I had not up to this point because it will mean hundreds of errors for things we haven't implemented yet, but I suppose that's a good way to know what's left too :-)

There's no harm in pulling in this test now if it's just from MRI, since we'll run their tests soon.

@headius headius merged commit 5af83bd into jruby:ruby-2.5 Feb 20, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@headius headius added this to the JRuby 9.2.0.0 milestone Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment