Fix a naming conflict jrubyc can introduce in generated java. #894
Conversation
A ruby argument named 'result' will conflict with the stack local used for the return value: both will become 'ruby_result' in java. Namespace arguments away from this by prefixing them with 'ruby_arg_' instead of merely 'ruby_'. See #812
|
Won't an argument named 'arg_result' still have the same issue? Not saying this isn't an improvement due to likelihood... |
|
A ruby argument named |
headius
added a commit
that referenced
this pull request
Jul 24, 2013
…esult-is-already-defined Fix a naming conflict jrubyc can introduce in generated java.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A ruby argument named
resultwill conflict with the stack local used for the return value: both will becomeruby_resultin java.Namespace arguments away from this by prefixing them with
ruby_arg_instead of merelyruby_.See #812