Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix a naming conflict jrubyc can introduce in generated java. #894
Conversation
This comment has been minimized.
This comment has been minimized.
|
Won't an argument named 'arg_result' still have the same issue? Not saying this isn't an improvement due to likelihood... |
This comment has been minimized.
This comment has been minimized.
|
A ruby argument named |
headius
added a commit
that referenced
this pull request
Jul 24, 2013
headius
merged commit 8135012
into
jruby:master
Jul 24, 2013
1 check passed
default
The Travis CI build passed
Details
phs
deleted the
phs:phs/issue-812-jrubyc-variable-ruby_result-is-already-defined
branch
Jan 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
phs commentedJul 18, 2013
A ruby argument named
resultwill conflict with the stack local used for the return value: both will becomeruby_resultin java.Namespace arguments away from this by prefixing them with
ruby_arg_instead of merelyruby_.See #812