Speed up templateHelper's getAncestor() by 500x #2150
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2025
|
Makes sense to me! I'll backport this fix to JSDoc 4.x and release a new version shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to adopt JSDoc in Three.js and one of the issues we're facing is that it takes 2 minutes to generate the docs.
I used Claude to profile the build script down to JSDoc's own code to try to pin point where the bottleneck was and eventually we figured out that
getAncestors()was the culprit. After this optimization the docs take only 16 seconds to generate.Please note that I've not studied the code myself but the docs generate as they used to.
/fyi @Mugen87 @donmccurdy @WestLangley @Methuselah96 @DefinitelyMaybe