Prettier

[mattgrill]

• prettier
• run prettier

[dawehner]

I love trailing comma all!

[dawehner]

I tried to compare what eslint-plugin-prettier does: https://github.com/prettier/eslint-plugin-prettier#recommended-configuration vs. what https://github.com/facebook/create-react-app/blob/next/packages/eslint-config-react-app/index.js does. Given we already try to go down the airbnb ruleset in core, I think using the same here makes sense.

[dawehner]

Can't you just use "prettier"? It'll pick up things in node_modules/.bin/prettier automatically

[mattgrill]

Yeah, you can. I just always try and be specific.

[dawehner]

+1 from me. Following airbnb instead of the custom ruleset of CRA seems sensible (it'll also avoid conversations when we merge it into core)

[justafish]

When CRA is running the dev server it's running eslint automatically on re-compile - is it running this new configuration instead of default?

[justafish]

Let's ditch jsx completely

[mattgrill]

We can, however there are some tests that are .js but they contain JSX. I don't care either way which is why I added this.

[mattgrill]

@justafish I just looked into this, if you add an .eslintrc.json it picks it up.

[justafish]

• jest, and serviceworker

[justafish]

Just the linting errors themselves that need fixing now 👍

[justafish]

So one thing I don't understand about adding eslint-config-prettier is it says that it "Turns off all rules that are unnecessary or might conflict with Prettier." - so what is enforcing the rules that it's turned off? Running prettier is something that each person needs to have done manually (or setup to do automatically on save, but still). If that is the case, then I would have thought our prettier config would be setup to help you follow the standards we've adopted (airbnb in this case), and so I'm not sure what this plugin actually does?

[justafish]

Ok I read https://prettier.io/docs/en/eslint.html and I get it now 👍