-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate ECMAScript version options #2124
Comments
Related / duplicated -> #1148 |
I'm implementing this option without removing I've two questions:
|
IMO
|
If JSHint throws an Invalid option warning fot that code, it also should throw it for
I meant this: // jshint es5: false
var x = {
get a() {} // es5 syntax, but jshint doesn't warn
}; |
This option (which may be set to 3, 5, or 6 / 2015) should replace `es3`, `es5` and `esnext`. This: - precludes invalid configurations like `es3: false, es5: true` - scales better for future versions of ECMAScript - eliminates the ambiguity of `esnext` (whose meaning has changed now that ES6 has been finalized) This commit partially fixes jshint#2124
This option (which may be set to 3, 5, or 6 / 2015) should replace `es3`, `es5` and `esnext`. This: - precludes invalid configurations like `es3: false, es5: true` - scales better for future versions of ECMAScript - eliminates the ambiguity of `esnext` (whose meaning has changed now that ES6 has been finalized) This commit partially fixes jshint#2124
This option (which may be set to 3, 5, or 6 / 2015) should replace `es3`, `es5` and `esnext`. This: - precludes invalid configurations like `es3: false, es5: true` - scales better for future versions of ECMAScript - eliminates the ambiguity of `esnext` (whose meaning has changed now that ES6 has been finalized) This commit partially fixes jshint#2124
This option (which may be set to 3, 5, or 6 / 2015) should replace `es3`, `es5` and `esnext`. This: - precludes invalid configurations like `es3: false, es5: true` - scales better for future versions of ECMAScript - eliminates the ambiguity of `esnext` (whose meaning has changed now that ES6 has been finalized) This commit partially fixes jshint#2124
This option (which may be set to 3, 5, or 6 / 2015) should replace `es3`, `es5` and `esnext`. This: - precludes invalid configurations like `es3: false, es5: true` - scales better for future versions of ECMAScript - eliminates the ambiguity of `esnext` (whose meaning has changed now that ES6 has been finalized) This commit partially fixes jshint#2124
Couldn't |
Replace boolean options
es3
,es5
, andesnext
with a single option namedesversion
that may be set to3
,5
, or6
. This:es3: false, es5: true
esnext
(whose meaning will change when ES6 is finalized)This is definitely a breaking change and should be implemented for the next major release of JSHint (if at all).
The text was updated successfully, but these errors were encountered: