Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] [jsk_topic_tools] warning when using rosrun and there is no subscriber for seconds #1132

Closed
wkentaro opened this issue Sep 19, 2015 · 7 comments

Comments

@wkentaro
Copy link
Member

why not add this feature to jsk_topic_tools/ConnectedBasedNodelet?
This feature is similar as warning when we run image_view without remapping image topic.

notice

  • And this is only for rosrun.
  • warning should be only once.
  • warning will appear after around 2~5 seconds.

maybe using timer with callback function and flag to avoid many warnings.

@garaemon
Copy link
Member

This kind of information is available on /diagnostics.
ConnectoinBasedNodelet publishes information about publishers and their subscribers to diagnostics.

@wkentaro
Copy link
Member Author

Oh, sorry. I mean this is not for professionals but for beginners. (I think
the warning of image_view is also for beginners.)

2015年9月19日土曜日、Ryohei Uedanotifications@github.comさんは書きました:

This kind of information is available on /diagnostics.
ConnectoinBasedNodelet publishes information about publishers and their
subscribers to diagnostics.


Reply to this email directly or view it on GitHub
#1132 (comment)
.

和田 健太郎 / Kentaro Wada
http://wkentaro.com

@garaemon
Copy link
Member

I agree that those kinds of warning helps us a lot, OTH I can easily imagine users say
"I have these warning message, this is a problem" and I will answer "It is an expected warning because no program require output yet ".

@wkentaro
Copy link
Member Author

This idea came from my experience, and I think this is useful for people
who are willing to resolve problems by theirselves. This can save their
time.

I think I understood your concern, that's true the warning does not work
for people who do not read the warning message well.

2015年9月21日月曜日、Ryohei Uedanotifications@github.comさんは書きました:

I agree that those kinds of warning helps us a lot, OTH I can easily
imagine users say
"I have these warning message, this is a problem" and I will answer "It is
an expected warning because no program require output yet ".


Reply to this email directly or view it on GitHub
#1132 (comment)
.

和田 健太郎 / Kentaro Wada
http://wkentaro.com

@garaemon
Copy link
Member

OK, let's see how it is useful. Please implement that feature.

@wkentaro
Copy link
Member Author

I'm planning to use roscpp::Timer with oneshot argument.
Do you agree with this way?

@garaemon
Copy link
Member

WallTimer sounds better

wkentaro added a commit to wkentaro/jsk_common that referenced this issue Sep 29, 2015
Closes jsk-ros-pkg#1132

The warning message should be write with ROS_INFO,
for no many warning when running with roslaunch.
wkentaro added a commit to wkentaro/jsk_common that referenced this issue Sep 29, 2015
Closes jsk-ros-pkg#1132

The warning message should be write with ROS_INFO,
for no many warning when running with roslaunch.
wkentaro added a commit to wkentaro/jsk_common that referenced this issue Sep 29, 2015
Closes jsk-ros-pkg#1132

The warning message should be write with ROS_INFO,
for no many warning when running with roslaunch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants