Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone_complexed_nodelet: add params key for each nodelet #1614

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

furushchev
Copy link
Member

   nodelets:
     -  name: node_name
        type: nodelet_type
        remappings:
          - from: from_topic
            to: to_topic
          - from: from_topic
            to: to_topic
        params:  # This is supported in this PR.
          - name: approximate_sync
            value: true
          - name: queue_size
            value: 100
     -  name: node_name2
        type: nodelet_type2
        if: false
     -  name: node_name3
        type: nodelet_type3
        unless: false

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@furushchev please add more info. who uses this feature?

@furushchev
Copy link
Member Author

@k-okada Okay, standalone_complexed_nodelet is a workaround for the issue #1531 and is, for example, used on demo packages for stability.

Using an example above, formerly we had to create a launch file likw as followings:

<launch>
  <node name="manager" pkg="jsk_topic_tools" type="standalone_complexed_nodelet">
    <rosparam>
   nodelets:
     -  name: node1
        type: nodelet_type
        remappings:
          - from: from_topic
            to: to_topic
          - from: from_topic
            to: to_topic
     -  name: node2
        type: nodelet_type2
        if: false
     -  name: node3
        type: nodelet_type3
        unless: false
    </rosparam>
  </node>

  <rosparam ns="node1">
   approximate_sync: true
   queue_size: 100
  </rosparam>
</launch>

There, parameters are defined separately from declaration of nodelets.

@knorth55 knorth55 self-assigned this Apr 12, 2019
@knorth55
Copy link
Member

PR2 uses this feature.

@k-okada k-okada merged commit 2afdcb7 into jsk-ros-pkg:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants