Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[merge after #772] [jsk_ik_server] add fetch ik reachability map script #769

Merged
merged 9 commits into from
Sep 9, 2021
Merged

[merge after #772] [jsk_ik_server] add fetch ik reachability map script #769

merged 9 commits into from
Sep 9, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jul 13, 2021 •
edited
Loading

please merge afte #772

roscd jsk_ik_server/scripts/ik-grid
bash fetch.sh

IK with x-up, rotation-axis :z

fetch-xup-iterate009 csv
fetch-xup-iterate009-concatenated

IK with y-up, rotation-axis :z

fetch-yup-iterate009 csv
fetch-yup-iterate009-concatenated

IK with z-up, rotation-axis :z

fetch-zup-iterate009 csv
fetch-zup-iterate009-concatenated

@knorth55
Copy link
Member Author

@708yamaguchi can you check this script?

708yamaguchi
708yamaguchi reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this PR works nicely.

It would be helpful if you add usage (the following script) to README.md

roscd jsk_ik_server/scripts/ik-grid
bash fetch.sh

I spent some time to find this script.

@knorth55
Copy link
Member Author

@708yamaguchi thanks, I add readme in #772

708yamaguchi
708yamaguchi approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

k-okada
k-okada reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add this image to README?

@knorth55 knorth55 changed the title [jsk_ik_server] add fetch ik reachability map script [merge after #772] [jsk_ik_server] add fetch ik reachability map script Jul 14, 2021
@knorth55
Copy link
Member Author

@k-okada thank you for your review. I add fetch IK reachability map images in readme.md

@k-okada k-okada merged commit 918e23b into jsk-ros-pkg:master Sep 9, 2021
@knorth55 knorth55 deleted the ik-reachability-fetch branch September 9, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada left review comments

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knorth55 @k-okada @708yamaguchi