Skip to content

Fix compaction on scoped contexts based on @type #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2018
Merged

Fix compaction on scoped contexts based on @type #594

merged 1 commit into from
Feb 26, 2018
+67 −14

Conversation

gkellogg
Copy link
Member

Look at term contexts from @type before starting to compact object members. Adds test.

Fixes #546.

@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Feb 19, 2018
@gkellogg gkellogg self-assigned this Feb 19, 2018
@gkellogg
Copy link
Member Author

Ruby implementation is here

niklasl
niklasl approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azaroth42 azaroth42 merged commit abd137d into master Feb 26, 2018
@gkellogg gkellogg deleted the issue-546 branch February 26, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasl niklasl niklasl approved these changes

@azaroth42 azaroth42 azaroth42 approved these changes

@davidlehn davidlehn Awaiting requested review from davidlehn

@dlongley dlongley Awaiting requested review from dlongley

Assignees

@gkellogg gkellogg

Labels
None yet
Projects
None yet
Milestone
JSON-LD 1.1 CG
Development

Successfully merging this pull request may close these issues.
3 participants
@gkellogg @niklasl @azaroth42