Skip to content

Remove the pruneBlankNodeIdentifiers option for framing #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2018
Merged

Remove the pruneBlankNodeIdentifiers option for framing #629

merged 1 commit into from
Apr 9, 2018

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Apr 2, 2018

and make it dependent on processing mode.

Fixes #627.

@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Apr 2, 2018
@gkellogg gkellogg requested review from dlongley and azaroth42 April 2, 2018 19:03
dlongley
dlongley approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps implementations may want to leave the option around so it can be turned on when doing 1.0 processing, however.

@azaroth42 azaroth42 merged commit 47e7f10 into master Apr 9, 2018
@gkellogg
Copy link
Member Author

gkellogg commented Apr 9, 2018

Resolved due to https://json-ld.org/minutes/2018-04-10/#resolution-2.

@gkellogg gkellogg deleted the issue-627 branch April 9, 2018 18:49
@davidlehn davidlehn mentioned this pull request Apr 13, 2018
Closed
@pjohnston-wiley pjohnston-wiley mentioned this pull request Jun 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@azaroth42 azaroth42 azaroth42 approved these changes

Assignees
No one assigned
Labels
framing spec-design
Projects
None yet
Milestone
JSON-LD 1.1 CG
Development

Successfully merging this pull request may close these issues.
3 participants
@gkellogg @dlongley @azaroth42