This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Use submodules #145
Merged
Use submodules #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
approved these changes
Aug 26, 2017
There was a problem hiding this comment.
I like this idea. I would like to get at least one additional approval from either @Relequestual or @awwright as I have not always correctly guessed how other folks prefer to manage the connections between the repos.
But I think this is a significant improvement.
Relequestual
approved these changes
Sep 1, 2017
|
Just one query. Where does "current" go / end up? |
Good catch: it ends up absolutely nowhere! Since it was the first entry clearly it was something I added while I was experimenting and I must not have gotten it completely removed. I have pushed a commit to do that now. |
|
Looks like all concerns were met, so I'm going to go ahead and merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes Git submodules to the spec repository for specification artifacts. This both ensures the served version matches the released version and shows where in history the artifacts come from.
Note: The desired hash for draft-05 and draft-06 could change as a result of json-schema-org/json-schema-spec#368.