feat: 🎸 add support for file creation

Author: streamich

src/nfs/v4/client/Nfsv4FsClient.ts

@@ -3,7 +3,7 @@ import * as misc from 'memfs/lib/node/types/misc';
 import * as opts from 'memfs/lib/node/types/options';
 import {nfs} from '../builder';
 import * as msg from '../messages';
-import {Nfsv4Stat, Nfsv4OpenAccess, Nfsv4OpenDeny, Nfsv4StableHow, Nfsv4Attr} from '../constants';
+import {Nfsv4Stat, Nfsv4OpenAccess, Nfsv4OpenDeny, Nfsv4StableHow, Nfsv4Attr, Nfsv4OpenFlags} from '../constants';
 import {Writer} from '@jsonjoy.com/buffers/lib/Writer';
 import {XdrEncoder} from '../../../xdr/XdrEncoder';
 
@@ -99,7 +99,14 @@ export class Nfsv4FsClient implements NfsFsClient {
     const openOwner = nfs.OpenOwner(BigInt(1), new Uint8Array([1, 2, 3, 4]));
     const claim = nfs.OpenClaimNull(filename);
     operations.push(
-      nfs.OPEN(0, Nfsv4OpenAccess.OPEN4_SHARE_ACCESS_WRITE, Nfsv4OpenDeny.OPEN4_SHARE_DENY_NONE, openOwner, 0, claim),
+      nfs.OPEN(
+        0,
+        Nfsv4OpenAccess.OPEN4_SHARE_ACCESS_WRITE,
+        Nfsv4OpenDeny.OPEN4_SHARE_DENY_NONE,
+        openOwner,
+        Nfsv4OpenFlags.OPEN4_CREATE,
+        claim,
+      ),
     );
     const writer = new Writer(16);
     const xdr = new XdrEncoder(writer);

src/nfs/v4/server/operations/node/Nfsv4OperationsNode.ts

@@ -9,6 +9,7 @@ import {
   Nfsv4OpenClaimType,
   Nfsv4DelegType,
   Nfsv4LockType,
+  Nfsv4OpenFlags,
 } from '../../../constants';
 import {Nfsv4OperationCtx, Nfsv4Operations} from '../Nfsv4Operations';
 import * as msg from '../../../messages';
@@ -535,33 +536,41 @@ export class Nfsv4OperationsNode implements Nfsv4Operations {
     const claimNull = request.claim.claim as struct.Nfsv4OpenClaimNull;
     const filename = claimNull.file;
     const filePath = NodePath.join(currentPathAbsolute, filename);
+    let fileExists = false;
     try {
       const stats = await this.promises.lstat(filePath);
       if (!stats.isFile()) {
         return new msg.Nfsv4OpenResponse(Nfsv4Stat.NFS4ERR_ISDIR);
       }
+      fileExists = true;
     } catch (err) {
-      if (isErrCode(err, 'ENOENT')) {
-        return new msg.Nfsv4OpenResponse(Nfsv4Stat.NFS4ERR_NOENT);
+      if (isErrCode('ENOENT', err)) {
+        if (request.openhow !== Nfsv4OpenFlags.OPEN4_CREATE) {
+          return new msg.Nfsv4OpenResponse(Nfsv4Stat.NFS4ERR_NOENT);
+        }
+      } else {
+        const status = normalizeNodeFsError(err, ctx.connection.logger);
+        return new msg.Nfsv4OpenResponse(status);
       }
-      const status = normalizeNodeFsError(err, ctx.connection.logger);
-      return new msg.Nfsv4OpenResponse(status);
     }
-    if (!this.canAccessFile(filePath, request.shareAccess, request.shareDeny)) {
+    if (fileExists && !this.canAccessFile(filePath, request.shareAccess, request.shareDeny)) {
       return new msg.Nfsv4OpenResponse(Nfsv4Stat.NFS4ERR_SHARE_DENIED);
     }
     let flags = 0;
     const isWrite = (request.shareAccess & Nfsv4OpenAccess.OPEN4_SHARE_ACCESS_WRITE) !== 0;
     const isRead = (request.shareAccess & Nfsv4OpenAccess.OPEN4_SHARE_ACCESS_READ) !== 0;
+    if (request.openhow === 1) {
+      flags = this.fs.constants.O_CREAT;
+    }
     if (isRead && isWrite) {
-      flags = this.fs.constants.O_RDWR;
+      flags |= this.fs.constants.O_RDWR;
     } else if (isWrite) {
-      flags = this.fs.constants.O_WRONLY;
+      flags |= this.fs.constants.O_WRONLY;
     } else {
-      flags = this.fs.constants.O_RDONLY;
+      flags |= this.fs.constants.O_RDONLY;
     }
     try {
-      const fd = await this.promises.open(filePath, flags);
+      const fd = await this.promises.open(filePath, flags, 0o644);
       const stateid = this.createStateid();
       const stateidKey = this.makeStateidKey(stateid);
       const openFile = new OpenFileState(