Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.1 release has breaking changes #110

Closed
mtscout6 opened this issue Jun 14, 2015 · 7 comments
Closed

2.5.1 release has breaking changes #110

mtscout6 opened this issue Jun 14, 2015 · 7 comments

Comments

@mtscout6
Copy link

mtscout6 commented Jun 14, 2015

2.5.0 is working as expected.

We are seeing a lot of failures in react-bootstrap failing the rule no-unused-vars when it is clearly used.

One such failing file is: https://github.com/react-bootstrap/react-bootstrap/blob/master/docs/examples/TooltipInCopy.js

It states that the variable LinkWithTooltip is not used, but it is used here: https://github.com/react-bootstrap/react-bootstrap/blob/master/docs/examples/TooltipInCopy.js#L15

mtscout6 added a commit to react-bootstrap/react-bootstrap that referenced this issue Jun 14, 2015
Due to breaking change in the 2.5.1 release.

See: jsx-eslint/eslint-plugin-react#110
@yannickcr
Copy link
Member

yannickcr commented Jun 14, 2015

OMG, I'm so sorry for this.

I'll investigate and shortly publish a fixed version.

mtscout6 added a commit to react-bootstrap/react-bootstrap that referenced this issue Jun 14, 2015
Due to breaking change in the 2.5.1 release.

See: jsx-eslint/eslint-plugin-react#110
@yannickcr
Copy link
Member

yannickcr commented Jun 14, 2015

Just published version 2.5.2 with a bugfix. Hope it will fix your issue.

@AlexKVal
Copy link
Contributor

AlexKVal commented Jun 14, 2015

There is still 2.5.1 version on npm
https://www.npmjs.com/package/eslint-plugin-react

@yannickcr
Copy link
Member

yannickcr commented Jun 14, 2015

It's published for real now :)

@AlexKVal
Copy link
Contributor

AlexKVal commented Jun 14, 2015

Thank you 🍒 😄

@AlexKVal
Copy link
Contributor

AlexKVal commented Jun 14, 2015

I've checked it - all is working fine, again. 🎉

@mtscout6
Copy link
Author

mtscout6 commented Jun 15, 2015

Thanks for the quick turn around on this :)

On Sun, Jun 14, 2015, 14:41 Alexander Shemetovsky notifications@github.com
wrote:

I've checked it - all is working fine, again. [image: 🎉]


Reply to this email directly or view it on GitHub
#110 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants