Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve title in void-dom-elements-no-children.md #1121

Merged
merged 1 commit into from Mar 22, 2017

Conversation

omerzach
Copy link
Contributor

@omerzach omerzach commented Mar 21, 2017

Add the name of the rule in parentheses at the end of Markdown title like in other documentation files.

Add the name of the rule in parentheses at the end of Markdown title like in other documentation files.
@ljharb
Copy link
Member

ljharb commented Mar 21, 2017

Replaces #1078

@@ -1,4 +1,4 @@
# Prevent void DOM elements (e.g. `<img />`, `<br />`) from receiving children
# Prevent void DOM elements (e.g. `<img />`, `<br />`) from receiving children (react/void-dom-elements-no-children)
Copy link
Member

@yannickcr yannickcr Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not put the react/ prefix in the other titles, I think it's not necessary to put it here either

Copy link
Member

@ljharb ljharb Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my request, per #1078 (comment)

Copy link
Member

@yannickcr yannickcr Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho, did now saw your comment and #1071. Ok then :)

ljharb
ljharb approved these changes Mar 22, 2017
@ljharb ljharb merged commit 9bb68c1 into jsx-eslint:master Mar 22, 2017
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants