Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prefer-es6-class): add missing prefix #1071

Merged
merged 2 commits into from May 16, 2017

Conversation

adnasa
Copy link
Contributor

@adnasa adnasa commented Feb 14, 2017

figured...

@ljharb
Copy link
Member

ljharb commented Feb 14, 2017

All of the rules docs omit the react/ prefix, by convention.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 14, 2017

@ljharb all of them?

at least from my side, this caused some confusion when setting up the config initially.

@adnasa adnasa changed the title docs(prefer-es6-class): correct typo in doc docs(prefer-es6-class): add missing prefix Feb 14, 2017
Copy link
Collaborator

@lencioni lencioni left a comment

I see this as an improvement. It would be nice to make them all consistent though.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 14, 2017

@lencioni yeah I agree on consistency 😉 let's do that (on a separate PR)!

@ljharb
Copy link
Member

ljharb commented Feb 14, 2017

As long as they're all the same, I'm happy :-) it'd be nice to update this PR to do all of them, but a separate one is fine too.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 15, 2017

you're right. we can do it in this PR

@adnasa
Copy link
Contributor Author

adnasa commented Feb 15, 2017

@ljharb @lencioni done

Copy link
Collaborator

@lencioni lencioni left a comment

Thanks!

@@ -1,4 +1,4 @@
# Prevent extra closing tags for components without children (self-closing-comp)
# Prevent extra closing tags for components without children (react/self-closing-comp)
Copy link
Collaborator

@lencioni lencioni Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have missed some other lines like this one (e.g. see require-optimization). It might be worth making another pass.

Copy link
Contributor Author

@adnasa adnasa Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, I wasn't supposed to add the prefix on the title. shall we proceed with this? 😛

@ljharb
Copy link
Member

ljharb commented Feb 18, 2017

@adnasa it looks like this needs a rebase, and it seems like #1078 has found a file that your PR doesn't update.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 18, 2017

@ljharb an update is coming up later this weekend 😉

@adnasa
Copy link
Contributor Author

adnasa commented Feb 19, 2017

@ljharb corrected the merge conflict 6334d63

@ljharb
Copy link
Member

ljharb commented Feb 19, 2017

@adnasa would you mind rebasing so as to remove the merge commit?

@adnasa adnasa force-pushed the typo-prefer-es6-class branch from 9622ac6 to 5a02508 Compare May 16, 2017
@adnasa
Copy link
Contributor Author

adnasa commented May 16, 2017

@ljharb Hey,
Sorry for being late on this! 😋
I finally did it, haha

ljharb
ljharb approved these changes May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants