New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(prefer-es6-class): add missing prefix #1071
Conversation
All of the rules docs omit the |
at least from my side, this caused some confusion when setting up the config initially. |
I see this as an improvement. It would be nice to make them all consistent though.
@lencioni yeah I agree on consistency |
As long as they're all the same, I'm happy :-) it'd be nice to update this PR to do all of them, but a separate one is fine too. |
you're right. we can do it in this PR |
@@ -1,4 +1,4 @@ | |||
# Prevent extra closing tags for components without children (self-closing-comp) | |||
# Prevent extra closing tags for components without children (react/self-closing-comp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have missed some other lines like this one (e.g. see require-optimization). It might be worth making another pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, I wasn't supposed to add the prefix on the title. shall we proceed with this?
@ljharb an update is coming up later this weekend |
@adnasa would you mind rebasing so as to remove the merge commit? |
@ljharb Hey, |
figured...