Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Needle dependency to fix errors #26

Merged
merged 1 commit into from
Jan 28, 2016

Conversation

brianhelba
Copy link
Collaborator

Prior to v0.7.9, Needle depended on a floating version of the "qs" library. The latest release of "qs" depends on ECMAScript6, which causes failures when running in any older Node environment.

Upgrading to the latest Needle fixes this issue. There are no compatibility changes between v0.6.1 and v0.11.0 that should cause issues:
https://github.com/tomas/needle/releases

Prior to v0.7.9, Needle depended on a floating version of the "qs" library.
The latest release of "qs" depends on ECMAScript6, which causes failures
when running in any older Node environment.

Upgrading to the latest Needle fixes this issue. There are no compatibility
changes between v0.6.1 and v0.11.0 that should cause issues:
https://github.com/tomas/needle/releases
@brianhelba
Copy link
Collaborator Author

@jubalm PTAL. I'd really like to use your library within our project, Girder, but this issue needs to be fixed first.

Once it's merged, you'll need to also push a new release to NPM.

rubensayshi added a commit that referenced this pull request Jan 28, 2016
Upgrade Needle dependency to fix errors
@rubensayshi rubensayshi merged commit f8dc31c into jubalm:master Jan 28, 2016
@rubensayshi
Copy link
Collaborator

hmm, I can merge but I can't release to NPM :(

@brianhelba brianhelba deleted the fix-deps branch January 28, 2016 16:12
@brianhelba
Copy link
Collaborator Author

Thanks @rubensayshi . Is it only @jubalm who does the NPM releases? Do you know if he's still active?

If he's not active (the last release to NPM was 2 years ago), I'm going to look into forking the repository, or seeing if the NPM maintainers can add permissions for someone else to release a new package.

This is a very useful tool, so I'd like to make sure it can be practically used in projects.

@brianhelba brianhelba mentioned this pull request Jan 28, 2016
@jubalm
Copy link
Owner

jubalm commented Jan 29, 2016

@brianhelba, apologies for the inactivity will be doing a quick bump with this PR today. You look like you have the most use-case for this repo, feel free to contribute :)

@simison
Copy link

simison commented Jan 29, 2016

@jubalm any changes adding @brianhelba and @rubensayshi rights to this repo and NPM? :-) Would be great!

@jubalm
Copy link
Owner

jubalm commented Jan 29, 2016

@simison sure, i've already added @rubensayshi as collaborator on npm but couldn't seem to figure out @brianhelba 's handle/account there. (Hmm it's really been a while, i thought i could privately message people round github then?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants