Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 8, 2021

@odow I noticed you keep the old jll's in the Compat (e.g., in jump-dev/Ipopt.jl#294). What's the reasoning behind this ? We want to force using the new jll so that we are usre it works on Mac OS ARM right ?

@blegat blegat requested a review from odow December 8, 2021 20:53
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #70 (7d46c0e) into master (2c9adef) will increase coverage by 3.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   51.12%   54.34%   +3.21%     
==========================================
  Files           8        8              
  Lines         753      782      +29     
==========================================
+ Hits          385      425      +40     
+ Misses        368      357      -11     
Impacted Files Coverage Δ
src/MOI_wrapper.jl 82.48% <0.00%> (+0.87%) ⬆️
src/declarations.jl 41.93% <0.00%> (+2.60%) ⬆️
src/declarations.h.jl 19.38% <0.00%> (+5.55%) ⬆️
src/blockmat.jl 61.43% <0.00%> (+5.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9adef...7d46c0e. Read the comment docs.

@blegat blegat merged commit ba908b3 into master Dec 8, 2021
@odow odow deleted the bl/jllv600.200.1+0 branch October 26, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants