Throw UnsupportedConstraint error in copy_to #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Oct 24, 2022
src/MOI_wrapper.jl
Outdated
| ) | ||
| vis_src = MOI.get(src, MOI.ListOfVariableIndices()) | ||
| if length(vis_src) < length(index_map.var_map) | ||
| if length(vis_src) != length(index_map.var_map) |
There was a problem hiding this comment.
Ooops. I guess this should be a separate PR. Is the current < correct? Shouldn't it be the other way around (or !=)?
odow
commented
Oct 24, 2022
Codecov ReportBase: 55.00% // Head: 55.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 55.00% 55.11% +0.11%
==========================================
Files 9 9
Lines 809 840 +31
==========================================
+ Hits 445 463 +18
- Misses 364 377 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
blegat
approved these changes
Oct 24, 2022
I think it is. But CSDP skips a lot of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79