Skip to content

Add tests for using ExprGraphs from NLP evaluators #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2020
Merged

Add tests for using ExprGraphs from NLP evaluators #1043

merged 4 commits into from
Mar 11, 2020

Conversation

joehuchette
Copy link
Contributor

@joehuchette joehuchette commented Mar 5, 2020 •
edited by odow
Loading

Edit(odow): Closes #624

joehuchette
joehuchette commented Mar 5, 2020
View reviewed changes
src/Test/nlp.jl
@@ -253,7 +277,7 @@ function feasibility_sense_test_template(model::MOI.ModelLike,

@test MOI.get(model, MOI.ObjectiveValue()) ≈ 0.0 atol=atol rtol=rtol

@test MOI.get(model, MOI.VariablePrimal(), x) ≈ 1.0 atol=atol rtol=rtol
@test abs(MOI.get(model, MOI.VariablePrimal(), x)) ≈ 1.0 atol=atol rtol=rtol
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is changing an existing test. I believe this is a bugfix, would be happy to split out into a separate PR if desired.

@odow
Copy link
Member

odow commented Mar 6, 2020

Looks like I never got around to finishing #624.

Tests?

@codecov-io
Copy link

codecov-io commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #1043 into master will increase coverage by 0.3%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1043     +/-   ##
=========================================
+ Coverage   95.23%   95.53%   +0.3%     
=========================================
  Files         100      100             
  Lines       11349    11447     +98     
=========================================
+ Hits        10808    10936    +128     
+ Misses        541      511     -30
Impacted Files Coverage Δ
src/Test/nlp.jl 40.74% <40%> (+20.51%) ⬆️
src/Test/intlinear.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fc0ea...7d86bbf. Read the comment docs.

@joehuchette
Copy link
Contributor Author

Ah, didn't see your old PR.

I added some tests for HS071, but I'm not sure if they're exactly what you had in mind. Let me know what you'd like to see.

@odow
Copy link
Member

odow commented Mar 6, 2020

I guess I had in mind testing the getting of the expressions.

@joehuchette
Copy link
Contributor Author

@odow Done.

@joehuchette
Copy link
Contributor Author

Not sure why codecov/patch is failing...

@joehuchette joehuchette merged commit 8f158e2 into master Mar 11, 2020
@blegat blegat added this to the v0.9.13 milestone Mar 24, 2020
@odow odow mentioned this pull request Apr 2, 2020
Closed
@odow odow deleted the nlp-exprgraph-test branch April 2, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubin mlubin mlubin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.9.13
Development

Successfully merging this pull request may close these issues.
5 participants
@joehuchette @odow @codecov-io @mlubin @blegat