-
Notifications
You must be signed in to change notification settings - Fork 92
Add ScaledPositiveSemidefiniteConeTriangle #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, we should:
- Add to docs
- Add tests to
MOI.Test
- Add a bridge for PSDCone -> ScaledPSDCone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add this to test_basic_constraints
:
MathOptInterface.jl/src/Test/test_basic_constraint.jl
Lines 101 to 103 in d5c3567
function _set(::Type{MOI.PositiveSemidefiniteConeTriangle}) | |
return MOI.PositiveSemidefiniteConeTriangle(3) | |
end |
:PositiveSemidefiniteConeTriangle, |
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
I changed to use an explicit length. Makes things simpler. |
Closes #531
Checklist from #2167
Basic
AbstractScalarSet
orAbstractVectorSet
tosrc/sets.jl
Base.copy(set::S)
Base.:(==)(x::S, y::S)
AbstractVectorSet
, implementdimension(set::S)
Utilities
AbstractVectorSet
, implementUtilities.set_dot
,unless the dot product between two vectors in the set is equivalent to
LinearAlgebra.dot
AbstractVectorSet
, implementUtilities.set_with_dimension
insrc/Utilities/matrix_of_constraints.jl
@model
macro at the bottom ofsrc/Utilities.model.jl
Documentation
along with an
## Example
block containing ajldoctest
docs/src/reference/standard_form.md
docs/src/manual/standard_form.md
Tests
_set(::Type{S})
method insrc/Test/test_basic_constraint.jl
and add the name of the set to the list at the bottom of that files
test/sets.jl
MathOptFormat
https://github.com/jump-dev/MathOptFormat
to addsupport for the new set New set: ScaledPositiveSemidefiniteConeTriangle MathOptFormat#27
Optional
dual_set(::S)
anddual_set_type(::Type{S})
Test
submodule exercising your new set