New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bridges] add SlackBridgePrimalDualStart #2194
Conversation
@assert value | ||
# ConstraintDual: if the objective function had a dual, it would be `-1` for | ||
# the Lagrangian function to be the same. | ||
if MOI.supports(model, MOI.ConstraintDualStart(), typeof(b.constraint)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem right, we should get an UnsupportedAttribute
error if it's not supported.
We should implement supports
for the bridge so that it returns false
if the constraint type does not support it. That way, it would be ignored by copy_to
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only ignore the Name
attribute. This is a special case because we want to pretend that every solver supports it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, maybe drop a comment here so that people see it's not the common way of handling starting values and it's not copy-pasted out of context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I would also assume it to always be |
Yeah. Or support passing something other than |
x-ref jump-dev/JuMP.jl#3271
@blegat, it seemed to me that we would never want to set this to something other than
-1
for the dual and0
for the slack primal, so I opted to consolidate everything into a single attribute.Does this seem right? Or am I missing something?