Add missing PSDCS in bridge cache #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
+ Coverage 95.57% 95.65% +0.07%
==========================================
Files 46 46
Lines 4678 4692 +14
==========================================
+ Hits 4471 4488 +17
+ Misses 207 204 -3
Continue to review full report at Codecov.
|
test/bridge.jl
Outdated
| @@ -162,6 +162,7 @@ MOIU.@model(NoRSOCModel, | |||
|
|
|||
| @testset "Combining two briges" begin | |||
| fullbridgedmock = MOIB.fullbridgeoptimizer(mock, Float64) | |||
| @test MOI.supports_constraint(fullbridgedmock, MOI.VectorAffineFunction{Float64}, MOI.PositiveSemidefiniteConeSquare) | |||
There was a problem hiding this comment.
This test doesn't fall under the "combining two bridges" header. Consider using a different testset.
test/bridge.jl
Outdated
| end | ||
| for F in [MOI.VectorOfVariables, MOI.VectorAffineFunction{Float64}, | ||
| MOI.VectorQuadraticFunction{Float64}] | ||
| @show F |
test/bridge.jl
Outdated
| MOI.GeometricMeanCone) | ||
| end | ||
| for F in [MOI.VectorOfVariables, MOI.VectorAffineFunction{Float64}] | ||
| # Missing vcat for quadratic for supporting quadratic |
There was a problem hiding this comment.
I don't understand these two comments. Are they TODOs?
test/bridge.jl
Outdated
| MOI.GeometricMeanCone) | ||
| end | ||
| for F in [MOI.VectorOfVariables, MOI.VectorAffineFunction{Float64}] | ||
| # TODO Missing vcat for quadratic for supporting quadratic |
There was a problem hiding this comment.
I still don't understand these TODOs and how they relate to the surrounding code. Are they implying that certain constraints are not yet supported? Which?
There was a problem hiding this comment.
These tests are not in the previous for because they do not support VectorQuadraticFunction yet
There was a problem hiding this comment.
Could you clarify that on the comments?
Let's tag MOI v0.6.1 once this is merged since this is a critical fix now that jump-dev/JuMP.jl#1468 is merged
Closes jump-dev/JuMP.jl#1476