Skip to content

Force Julia to specialize on ::Function arguments. #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Force Julia to specialize on ::Function arguments. #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf65f1e
Force Julia to specialize on ::Function arguments.
odow Mar 5, 2021
d7e9ce9
Undo some changes
odow Mar 7, 2021
7999159
Undo eval_variables
odow Mar 7, 2021
e0e0b83
Undo all_coefficients
odow Mar 7, 2021
a6c496c
Undo filter_variables
odow Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/Utilities/copy.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

"""
automatic_copy_to(dest::MOI.ModelLike, src::MOI.ModelLike;
copy_names::Bool=true,
copy_names::Bool=true,
filter_constraints::Union{Nothing, Function}=nothing)

Use [`Utilities.supports_default_copy_to`](@ref) and
Expand All @@ -11,8 +11,8 @@ Use [`Utilities.supports_default_copy_to`](@ref) and
apply the copy operation.

If the `filter_constraints` arguments is given, only the constraints for which
this function returns `true` will be copied. This function is given a
constraint index as argument.
this function returns `true` will be copied. This function is given a
constraint index as argument.
"""
function automatic_copy_to(
dest::MOI.ModelLike,
Expand Down Expand Up @@ -402,8 +402,8 @@ Copy the constraints `cis_src` from the model `src` to the model `dest` and fill
[`pass_attributes`] to copy the constraint attributes.

If the `filter_constraints` arguments is given, only the constraints for which
this function returns `true` will be copied. This function is given a
constraint index as argument.
this function returns `true` will be copied. This function is given a
constraint index as argument.
"""
function copy_constraints(
dest::MOI.ModelLike,
Expand Down Expand Up @@ -443,7 +443,7 @@ function pass_constraints(
filter_constraints::Union{Nothing,Function} = nothing,
)
# copy_constraints can also take a filter_constraints argument; however, filtering
# is performed within this function (because it also calls MOI.set on the constraints).
# is performed within this function (because it also calls MOI.set on the constraints).
# Don't pass this argument to copy_constraints/pass_cons to avoid a double filtering.
for (S, cis_src) in zip(single_variable_types, single_variable_indices)
if filter_constraints !== nothing
Expand Down Expand Up @@ -497,8 +497,8 @@ function copy_free_variables(
dest::MOI.ModelLike,
idxmap::IndexMap,
vis_src,
copy_variables::Function,
)
copy_variables::F,
) where {F<:Function}
if length(vis_src) != length(keys(idxmap.varmap))
vars = copy_variables(dest, length(vis_src) - length(idxmap.varmap))
i = 1
Expand Down Expand Up @@ -549,9 +549,9 @@ function try_constrain_variables_on_creation(
dest::MOI.ModelLike,
src::MOI.ModelLike,
idxmap,
copy_constrained_variables::Function,
copy_constrained_variable::Function,
)
copy_constrained_variables::F1,
copy_constrained_variable::F2,
) where {F1<:Function,F2<:Function}
single_or_vector_variables_types = sorted_variable_sets_by_cost(dest, src)
vector_of_variables_types = Type{<:MOI.AbstractVectorSet}[]
vector_of_variables_added =
Expand Down Expand Up @@ -605,8 +605,8 @@ constraints and attributes incrementally. The function
the copying a model incrementally.

If the `filter_constraints` arguments is given, only the constraints for which
this function returns `true` will be copied. This function is given a
constraint index as argument.
this function returns `true` will be copied. This function is given a
constraint index as argument.
"""
function default_copy_to(
dest::MOI.ModelLike,
Expand Down Expand Up @@ -972,7 +972,7 @@ function load_constraints(
end

"""
allocate_load(dest::MOI.ModelLike, src::MOI.ModelLike,
allocate_load(dest::MOI.ModelLike, src::MOI.ModelLike,
filter_constraints::Union{Nothing, Function}=nothing
)

Expand All @@ -981,8 +981,8 @@ Implements `MOI.copy_to(dest, src)` using the Allocate-Load API. The function
the Allocate-Load API.

If the `filter_constraints` arguments is given, only the constraints for which
this function returns `true` will be copied. This function is given a
constraint index as argument.
this function returns `true` will be copied. This function is given a
constraint index as argument.
"""
function allocate_load(
dest::MOI.ModelLike,
Expand Down
Loading