Skip to content

Add error checks for set dimensions #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 20, 2021
Merged

Add error checks for set dimensions #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ebc0e75
Add error checks for set dimensions
odow May 14, 2021
be15d9e
Fix
odow May 14, 2021
b381736
Fix Zeros(0)
odow May 14, 2021
563a965
Reduce dimension of some cones
odow May 17, 2021
38ed6b5
Reword errors
odow May 17, 2021
d6ff6df
Add ZeroDimSet
odow May 17, 2021
f38e422
Fix SDPA
odow May 17, 2021
40034b5
Fix
odow May 17, 2021
573be94
Allow empty sets
odow Jun 6, 2021
326f1e6
Update sets.jl
odow Jun 7, 2021
7efd7d9
Update SDPA.jl
odow Jun 18, 2021
db0c196
Update map.jl
odow Jun 18, 2021
58430a0
Update sets.jl
odow Jun 18, 2021
0e6076a
Update SDPA.jl
odow Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Bridges/Constraint/geomean.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ function bridge_constraint(
s::MOI.GeometricMeanCone,
) where {T,F,G,H}
d = s.dimension
if d <= 1
# TODO change to a standard error: https://github.com/jump-dev/MathOptInterface.jl/issues/967
error("Dimension of GeometricMeanCone must be greater than 1.")
end
n = d - 1
l = ilog2(n)
N = 1 << l
Expand Down
6 changes: 2 additions & 4 deletions src/FileFormats/SDPA/SDPA.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,8 @@ function Base.write(io::IO, model::Model{T}) where {T}
end
println(io)

index_map = Vector{Tuple{Int,Int}}(
undef,
MOI.dimension(MOI.PositiveSemidefiniteConeTriangle(max_dim)),
)
max_index_dim = MOI.dimension(MOI.PositiveSemidefiniteConeTriangle(max_dim))
index_map = Vector{Tuple{Int,Int}}(undef, max_index_dim)
k = 0
for col in 1:max_dim
for row in 1:col
Expand Down
Loading