Skip to content

Fix and add test for throwing UnsupportedSubmittable #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Fix and add test for throwing UnsupportedSubmittable #1393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b6b08
Fix and add test for throwing UnsupportedSubmittable
odow Jun 18, 2021
9bed5ec
Fix space
odow Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/attributes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,12 @@ function submit(model::ModelLike, sub::AbstractSubmittable, args...)
),
)
else
throw(UnsupportedSubmittable(sub))
throw(
UnsupportedSubmittable(
sub,
"submit(::$(typeof(model)), ::$(typeof(sub))) is not supported.",
),
)
end
end

Expand Down
12 changes: 12 additions & 0 deletions test/attributes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,18 @@ function test_ConstraintBasisStatus_fallback()
)
end

function test_UnsupportedSubmittable()
model = DummyModelWithAdd()
sub = MOI.LazyConstraint{Int}(1)
@test_throws(
MOI.UnsupportedSubmittable(
sub,
"submit(::$(typeof(model)), ::$(typeof(sub))) is not supported.",
),
MOI.submit(model, sub, 1),
)
end

function runtests()
for name in names(@__MODULE__; all = true)
if startswith("$name", "test_")
Expand Down