Skip to content

Improve error message of unsupported attributes in bridges #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Improve error message of unsupported attributes in bridges #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a991a41
Improve error message of unsupported attributes in bridges
odow Jun 21, 2021
b652689
Update zeros.jl
odow Jun 21, 2021
e5e19b2
Update bridge_optimizer.jl
odow Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Bridges/bridge.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,14 @@ function MOI.get(
)
return throw(
ArgumentError(
"Bridge of type `$(typeof(bridge))` does not support accessing the attribute `$attr`.",
"Bridge of type `$(typeof(bridge))` does not support accessing " *
"the attribute `$attr`. If you encountered this error " *
"unexpectedly, it probably means your model has been " *
"reformulated using the bridge, and you are attempting to query " *
"an attribute that we haven't implemented yet for this bridge. " *
"Please open an issue at https://github.com/jump-dev/MathOptInterface.jl/issues/new " *
"and provide a reproducible example explaining what you were " *
"trying to do.",
),
)
end
Expand Down
16 changes: 11 additions & 5 deletions test/Bridges/Variable/zeros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,19 @@ err = ArgumentError(
@test MOI.get(bridged_mock, MOI.ConstraintDual(), cx) == 0.0
@test MOI.get(bridged_mock, MOI.ConstraintDual(), c1) == 0.0
@test MOI.get(bridged_mock, MOI.ConstraintDual(), c2) == 1.0

bridge = MathOptInterface.Bridges.Variable.ZerosBridge{Float64}
attr = MOI.ConstraintDual()
err = ArgumentError(
"Bridge of type `MathOptInterface.Bridges.Variable.ZerosBridge{Float64}`" *
" does not support accessing the attribute" *
" `MathOptInterface.ConstraintDual(1)`.",
"Bridge of type `$(bridge)` does not support accessing " *
"the attribute `$attr`. If you encountered this error " *
"unexpectedly, it probably means your model has been " *
"reformulated using the bridge, and you are attempting to query " *
"an attribute that we haven't implemented yet for this bridge. " *
"Please open an issue at https://github.com/jump-dev/MathOptInterface.jl/issues/new " *
"and provide a reproducible example explaining what you were " *
"trying to do.",
)
@test_throws err MOI.get(bridged_mock, MOI.ConstraintDual(), cyz)
@test_throws err MOI.get(bridged_mock, attr, cyz)
end

@testset "Query" begin
Expand Down
17 changes: 15 additions & 2 deletions test/Bridges/bridge_optimizer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,23 @@ bridged_mock = MOIB.Constraint.LessToGreater{Float64}(
)

@testset "Unsupported constraint attribute" begin
bridge = MOI.Bridges.Constraint.SplitIntervalBridge{
Float64,
MOI.SingleVariable,
MOI.Interval{Float64},
MOI.GreaterThan{Float64},
MOI.LessThan{Float64},
}
attr = MOIT.UnknownConstraintAttribute()
err = ArgumentError(
"Bridge of type `$(MOI.Bridges.Constraint.SplitIntervalBridge{Float64,MOI.SingleVariable,MOI.Interval{Float64},MOI.GreaterThan{Float64},MOI.LessThan{Float64}})` " *
"does not support accessing the attribute `$attr`.",
"Bridge of type `$(bridge)` does not support accessing " *
"the attribute `$attr`. If you encountered this error " *
"unexpectedly, it probably means your model has been " *
"reformulated using the bridge, and you are attempting to query " *
"an attribute that we haven't implemented yet for this bridge. " *
"Please open an issue at https://github.com/jump-dev/MathOptInterface.jl/issues/new " *
"and provide a reproducible example explaining what you were " *
"trying to do.",
)
x = MOI.add_variable(bridged_mock)
ci = MOI.add_constraint(
Expand Down