Rename IndicatorSet to Indicator. #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Jul 18, 2021
|
It makes sense to first do the MOF part, then import it into MOI. I've added a commit to revert those changes. |
This was referenced Jul 18, 2021
odow
reviewed
Jul 22, 2021
|
The tests now pass; there are still format checks that fail, but not for the altered part of the code. |
That's weird, it's passing on master: https://github.com/jump-dev/MathOptInterface.jl/runs/3147720574 |
This is more consistent with the naming of the other sets.
|
Do I need to do anything more in this PR? CI accepted a previous version of the patch, and there were only cosmetic changes in between. |
|
I just cycled the CI. If it doesn't work, we probably just need to rebase the branch. |
odow
reviewed
Aug 2, 2021
|
Having a new cycle of CI seems to have solved the issue, but let's see what happens with the new commit… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more consistent with the naming of the other sets.
Follows #1459.
I also renamed through MOF, I don't know if this should happen (or maybe tag a new version of MOF JSON schema?).
There is only one occurrence of
IndicatorSetpresent, inNEWS.md.