Skip to content

Conversation

dourouc05
Copy link
Contributor

No description provided.

@dourouc05 dourouc05 changed the title Improve documentation about bridges [docs] Improve documentation about bridges Aug 3, 2021
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will be very useful

@dourouc05 dourouc05 changed the title [docs] Improve documentation about bridges [WIP] [docs] Improve documentation about bridges Aug 3, 2021
@dourouc05 dourouc05 changed the title [WIP] [docs] Improve documentation about bridges [docs] Improve documentation about bridges Aug 4, 2021
@dourouc05
Copy link
Contributor Author

I think it's quite complete, at least to create a constraint bridge. You could still add a lot to it, no doubt (like mapping dual warm starts), but I think that's outside the scope of what a primer tutorial should have on the topic.

What do you think of it?

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you have more to add? We can always add more later in follow-up PRs.

@dourouc05
Copy link
Contributor Author

I don't have any more ideas for now. The last few commits were just to ensure that the doc compiles. In particular, I added the docs for many structs, it would be nice to have a second view on those (I also had to write a little something for MockOptimizer).

@odow
Copy link
Member

odow commented Aug 4, 2021

I'll merge once CI finishes. This is very helpful thank you!

@dourouc05
Copy link
Contributor Author

Finally, CI passes!

@odow odow merged commit 6380182 into jump-dev:master Aug 4, 2021
@dourouc05 dourouc05 deleted the doc-bridges branch August 4, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants