Skip to content

[FileFormats.NL] Fix printing of large integers #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021
Merged

[FileFormats.NL] Fix printing of large integers #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/FileFormats/NL/NL.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,12 @@ function _process_constraint(
return
end

_str(x::Float64) = isinteger(x) ? string(round(Int, x)) : string(x)
function _str(x::Float64)
if isinteger(x) && (typemin(Int) <= x <= typemax(Int))
return string(round(Int, x))
end
return string(x)
end

_write_term(io, x::Float64, ::Any) = println(io, "n", _str(x))
_write_term(io, x::Int, ::Any) = println(io, "o", x)
Expand Down
8 changes: 8 additions & 0 deletions test/FileFormats/NL/NL.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,14 @@ function test_moi()
return
end

function test_float_rounding()
@test NL._str(1.0) == "1"
@test NL._str(1.2) == "1.2"
@test NL._str(1e50) == "1.0e50"
@test NL._str(-1e50) == "-1.0e50"
return
end

function runtests()
for name in names(@__MODULE__; all = true)
if startswith("$(name)", "test_")
Expand Down