[Test] add generic number types in test_linear #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2021
joaquimg
reviewed
Nov 19, 2021
src/Test/test_linear.jl
Outdated
| @@ -190,7 +174,7 @@ function test_linear_integration( | |||
| else | |||
| MOI.delete(model, c) | |||
| cf = MOI.ScalarAffineFunction{T}( | |||
| MOI.ScalarAffineTerm{T}.([one(T), one(T), one(T)], v), | |||
| MOI.ScalarAffineTerm{T}.(one(T), v), | |||
There was a problem hiding this comment.
I switched to T(1) and T(0). We assume you can go T(3), so we might as well go all-in.
joaquimg
requested changes
Nov 19, 2021
odow
force-pushed
the
od/generic-tests-linear
branch
from
aa9e76c to
a011e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #841