Skip to content

Fix bug in CachingOptimizer ConstraintPrimal #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Fix bug in CachingOptimizer ConstraintPrimal #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffa2460
Fix bug in CachingOptimizer ConstraintPrimal
odow Nov 23, 2021
7dd7620
Fix
odow Nov 24, 2021
97190aa
Update cachingoptimizer.jl
odow Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Utilities/cachingoptimizer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,7 @@ function MOI.get(
"optimizer is attached.",
)
end
MOI.check_result_index_bounds(model, attr)
try
return MOI.get(
model.optimizer,
Expand All @@ -923,6 +924,7 @@ function MOI.get(
"optimizer is attached.",
)
end
MOI.check_result_index_bounds(model, attr)
try
return MOI.get(
model.optimizer,
Expand Down
10 changes: 10 additions & 0 deletions test/Utilities/cachingoptimizer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,8 @@ MOI.get(::_ConstraintPrimal1310, ::MOI.ListOfModelAttributesSet) = []

MOI.get(::_ConstraintPrimal1310, ::MOI.PrimalStatus) = MOI.FEASIBLE_POINT

MOI.get(::_ConstraintPrimal1310, ::MOI.ResultCount) = 1

function MOI.optimize!(::_ConstraintPrimal1310, model::MOI.ModelLike)
index_map = MOI.IndexMap()
for x in MOI.get(model, MOI.ListOfVariableIndices())
Expand Down Expand Up @@ -845,6 +847,14 @@ function test_ConstraintPrimal_fallback()
MOI.optimize!(model)
@test MOI.get(model, MOI.ConstraintPrimal(), c) == 1.2
@test MOI.get(model, MOI.ConstraintPrimal(), [c]) == [1.2]
@test_throws(
MOI.ResultIndexBoundsError(MOI.ConstraintPrimal(2), 1),
MOI.get(model, MOI.ConstraintPrimal(2), c),
)
@test_throws(
MOI.ResultIndexBoundsError(MOI.ConstraintPrimal(2), 1),
MOI.get(model, MOI.ConstraintPrimal(2), [c]),
)
return
end

Expand Down