Skip to content

[Utilities] Fix method invalidation #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2021
Merged

[Utilities] Fix method invalidation #1692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bda5ce
[Utilities] Fix method invalidation
odow Nov 30, 2021
030bd8b
Update functions.jl
odow Nov 30, 2021
0182dae
Update functions.jl
odow Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/Utilities/functions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3190,7 +3190,22 @@ function Base.one(F::Type{<:TypedScalarLike{T}}) where {T}
return convert(F, one(T))
end

Base.promote_rule(::Type{F}, ::Type{T}) where {T,F<:TypedScalarLike{T}} = F
# !!! note
# These two `promote_rules` are written explicitly instead of
# `TypedScalarLike` in order to avoid a method invalidation.
function Base.promote_rule(
F::Type{MOI.ScalarAffineFunction{T}},
::Type{T},
) where {T}
return F
end

function Base.promote_rule(
F::Type{MOI.ScalarQuadraticFunction{T}},
::Type{T},
) where {T}
return F
end

function operate_coefficient(f, term::MOI.ScalarAffineTerm)
return MOI.ScalarAffineTerm(f(term.coefficient), term.variable)
Expand Down