Skip to content

Throw DeleteNotAllowed when deleted constraint index of bridged varaiables #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Throw DeleteNotAllowed when deleted constraint index of bridged varaiables #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8f4e95
Throw DeleteNotAllowed when deleted constraint index of bridged varia…
blegat Feb 23, 2022
aac3cda
Update bridge_optimizer.jl
odow Feb 23, 2022
179b1c7
Update src/Bridges/bridge_optimizer.jl
odow Feb 23, 2022
bc02e3f
Fix
odow Feb 23, 2022
b815fc1
Remove perf file
odow Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Bridges/bridge_optimizer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,10 +569,13 @@ function MOI.delete(b::AbstractBridgeOptimizer, ci::MOI.ConstraintIndex)
MOI.throw_if_not_valid(b, ci)
br = bridge(b, ci)
if is_variable_bridged(b, ci)
error(
"Cannot delete constraint index of bridged constrained",
" variables. Delete the scalar variable or the vector of",
" variables instead.",
throw(
MOI.DeleteNotAllowed(
ci,
"Cannot delete constraint index of bridged constrained " *
"variables. Delete the scalar variable or the vector of " *
"variables instead.",
),
)
else
delete!(Constraint.bridges(b), ci)
Expand Down
7 changes: 4 additions & 3 deletions test/Bridges/Variable/zeros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,10 @@ function test_zeros()
MOI.Bridges.IndexInVector(2),
) === nothing

err = ErrorException(
"Cannot delete constraint index of bridged constrained variables. Delete" *
" the scalar variable or the vector of variables instead.",
err = MOI.DeleteNotAllowed(
cyz,
"Cannot delete constraint index of bridged constrained variables. " *
"Delete the scalar variable or the vector of variables instead.",
)
@test_throws err MOI.delete(bridged_mock, cyz)

Expand Down