Skip to content

[Bridges] fix UnsupportedAttribute in function_conversion.jl #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2022
Merged

[Bridges] fix UnsupportedAttribute in function_conversion.jl #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b56932b
[Bridges] fix UnsupportedAttribute in function_conversion.jl
odow Feb 28, 2022
4e50ef6
Fix test
odow Feb 28, 2022
6c6afea
Update src/Bridges/Constraint/function_conversion.jl
odow Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Bridges/Constraint/function_conversion.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ function MOI.get(
return MOI.get(model, attr, bridge.constraint)
else
throw(
ArgumentError(
"Bridge of type `$(typeof(bridge))` does not support accessing the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
MOI.UnsupportedAttribute(
attr,
"Bridge of type `$(typeof(bridge))` does not support getting the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
),
)
end
Expand All @@ -40,7 +41,8 @@ function MOI.set(
)
if !invariant_under_function_conversion(attr)
throw(
ArgumentError(
MOI.UnsupportedAttribute(
attr,
"Bridge of type `$(typeof(bridge))` does not support setting the attribute `$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
),
)
Expand Down
28 changes: 20 additions & 8 deletions test/Bridges/Constraint/functionize.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,21 @@ function test_scalar_functionize_linear2()
Float64,
MOI.GreaterThan{Float64},
}
err = ArgumentError(
"Bridge of type `$(BT)` does not support setting the attribute " *
"`$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
function _unsupported_attribute(attr, f)
return MOI.UnsupportedAttribute(
attr,
"Bridge of type `$(BT)` does not support $(f)ting the attribute " *
"`$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
)
end
@test_throws(
_unsupported_attribute(attr, "set"),
MOI.set(bridged_mock, attr, ci, 1.0),
)
@test_throws err MOI.set(bridged_mock, attr, ci, 1.0)
err = ArgumentError(
"Bridge of type `$(BT)` does not support accessing the attribute " *
"`$attr` because `MOIB.Constraint.invariant_under_function_conversion($attr)` returns `false`.",
@test_throws(
_unsupported_attribute(attr, "get"),
MOI.get(bridged_mock, attr, ci),
)
@test_throws err MOI.get(bridged_mock, attr, ci)
for (i, ci) in enumerate(cis)
_test_delete_bridge(
bridged_mock,
Expand Down Expand Up @@ -206,6 +211,13 @@ function test_vector_functionize_lin1v()
return
end

function test_unsupported_attribute_issue_1758()
inner = MOI.Utilities.Model{Float64}()
model = MOI.Bridges.Constraint.ScalarFunctionize{Float64}(inner)
MOI.Test.test_model_copy_to_UnsupportedAttribute(model, MOI.Test.Config())
return
end

end # module

TestConstraintFunctionize.runtests()