[Bridges] fix tests for SplitComplexZerosBridge #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
added
Submodule: Bridges
blegat
reviewed
Jul 14, 2022
| @@ -34,6 +34,7 @@ struct SplitComplexZerosBridge{ | |||
| G<:MOI.Utilities.TypedLike{Complex{T}}, | |||
| } <: AbstractBridge | |||
| dimension::Int | |||
| func::G # Simplify querying ConstraintFunction. | |||
There was a problem hiding this comment.
We don't want to simplify it. It's ok for it to be slow. However, we want bridges to have low memory footprint
There was a problem hiding this comment.
I've been prioritizing correctness and completeness over performance. But yeah, we can fix this in a different PR if you like.
There was a problem hiding this comment.
Yes, thanks for making the bridges tests working with complex! Just wanted to check we're on the same page about this which is why I also clarified it in the docs now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of little niggly things here shows how hard it is to write a bridge without these new tests.