Skip to content

[Bridges] fix adjoint functions in SetDotInverseScalingBridge #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023
Merged

[Bridges] fix adjoint functions in SetDotInverseScalingBridge #2264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b81bb5
[Bridges] fix adjoint functions in SetDotInverseScalingBridge
odow Sep 6, 2023
656c9e1
Add tests
odow Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Bridges/Constraint/bridges/set_dot_scaling.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,14 @@ function MOI.Bridges.adjoint_map_function(
::Type{<:SetDotInverseScalingBridge{T,S}},
func,
) where {T,S}
return _inverse_scale(T, S, func)
return _scale(T, S, func)
end

function MOI.Bridges.inverse_adjoint_map_function(
::Type{<:SetDotInverseScalingBridge{T,S}},
func,
) where {T,S}
return _scale(T, S, func)
return _inverse_scale(T, S, func)
end

# Since the set type is not defined, the default `MOI.supports_constraint`
Expand Down
36 changes: 36 additions & 0 deletions test/Bridges/Constraint/set_dot_scaling.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,42 @@ function test_inverse_scaling_quadratic()
return
end

function test_set_dot_scaling_constraint_dual_start()
inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
model = MOI.Bridges.Constraint.SetDotScaling{Float64}(inner)
x = MOI.add_variables(model, 3)
c = MOI.add_constraint(
model,
MOI.VectorOfVariables(x),
MOI.PositiveSemidefiniteConeTriangle(2),
)
MOI.set(model, MOI.ConstraintDualStart(), c, [1.0, 1.0, 1.0])
@test MOI.get(model, MOI.ConstraintDualStart(), c) ≈ [1.0, 1.0, 1.0]
F = MOI.VectorAffineFunction{Float64}
S = MOI.Scaled{MOI.PositiveSemidefiniteConeTriangle}
d = MOI.get(inner, MOI.ListOfConstraintIndices{F,S}())[1]
@test MOI.get(inner, MOI.ConstraintDualStart(), d) ≈ [1.0, √2, 1.0]
return
end

function test_set_dot_inverse_scaling_constraint_dual_start()
inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
model = MOI.Bridges.Constraint.SetDotInverseScaling{Float64}(inner)
x = MOI.add_variables(model, 3)
c = MOI.add_constraint(
model,
MOI.VectorOfVariables(x),
MOI.ScaledPositiveSemidefiniteConeTriangle(2),
)
MOI.set(model, MOI.ConstraintDualStart(), c, [1.0, 1.0, 1.0])
@test MOI.get(model, MOI.ConstraintDualStart(), c) ≈ [1.0, 1.0, 1.0]
F = MOI.VectorAffineFunction{Float64}
S = MOI.PositiveSemidefiniteConeTriangle
d = MOI.get(inner, MOI.ListOfConstraintIndices{F,S}())[1]
@test MOI.get(inner, MOI.ConstraintDualStart(), d) ≈ [1.0, 1 / √2, 1.0]
return
end

end # module

TestConstraintSetDotScaling.runtests()