Skip to content

[Bridges] fix IndicatorToMILPBridge when z is not binary #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

[Bridges] fix IndicatorToMILPBridge when z is not binary #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Bridges/Constraint/bridges/IndicatorToMILPBridge.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,18 @@ end

MOI.Bridges.needs_final_touch(::IndicatorToMILPBridge) = true

function _is_binary(model::MOI.ModelLike, f::MOI.AbstractScalarFunction)
x = convert(MOI.VariableIndex, f)
return _is_binary(model, x)
end

function _is_binary(model::MOI.ModelLike, x::MOI.VariableIndex)
return MOI.is_valid(
model,
MOI.ConstraintIndex{MOI.VariableIndex,MOI.ZeroOne}(x.value),
)
end

function MOI.Bridges.final_touch(
bridge::IndicatorToMILPBridge{T,F},
model::MOI.ModelLike,
Expand All @@ -198,6 +210,10 @@ function MOI.Bridges.final_touch(
ret = MOI.Utilities.get_bounds(model, bounds, fi)
if ret === nothing
throw(MOI.Bridges.BridgeRequiresFiniteDomainError(bridge, fi))
elseif !_is_binary(model, scalars[1])
error(
"Unable to reformulate indicator constraint to a MILP. The indicator variable must be binary.",
)
end
if bridge.slack === nothing
# This is the first time calling final_touch
Expand Down
19 changes: 19 additions & 0 deletions test/Bridges/Constraint/IndicatorToMILPBridge.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,25 @@ function test_delete_before_final_touch()
return
end

function test_runtests_error_not_binary()
inner = MOI.Utilities.Model{Int}()
model = MOI.Bridges.Constraint.IndicatorToMILP{Int}(inner)
x = MOI.add_variables(model, 2)
MOI.add_constraint(model, x[2], MOI.Interval(0, 4))
c = MOI.add_constraint(
model,
MOI.VectorOfVariables(x),
MOI.Indicator{MOI.ACTIVATE_ON_ZERO}(MOI.GreaterThan(2)),
)
@test_throws(
ErrorException(
"Unable to reformulate indicator constraint to a MILP. The indicator variable must be binary.",
),
MOI.Bridges.final_touch(model),
)
return
end

end # module

TestConstraintIndicatorToMILP.runtests()
Loading