Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for libsoup3/webkit2gtk-4.1 #49

Closed
hovercats opened this issue Feb 7, 2022 · 2 comments
Closed

support for libsoup3/webkit2gtk-4.1 #49

hovercats opened this issue Feb 7, 2022 · 2 comments

Comments

@hovercats
Copy link

So, Ive been messing some with getting webkit2gtk to work with libsoup3, as I
wanted to keep libsoup up to date. This resulted in webkit no longer being 4.0,
but rather 4.1. in which wyeb does not seem to be compatible with at the moment.

I changed the lines with webkit2gtk*-4.0 to 4.1.
This results in the following output;

main.c: In function '_openuri': main.c:1327:17: error: unknown type name 'SoupURI' 1327 | SoupURI *suri = soup_uri_new(uri); | ^~~~~~~ ext.c: In function 'tofull': ext.c:374:9: error: unknown type name 'SoupURI' 374 | SoupURI *base = soup_uri_new(bases); | ^~~~~~~ ext.c:375:9: error: unknown type name 'SoupURI' 375 | SoupURI *full = soup_uri_new_with_base(base,uri); | ^~~~~~~ make: *** [makefile:14: wyeb] Error 1 make: *** Waiting for unfinished jobs.... ext.c: In function 'reqcb': ext.c:1827:9: error: unknown type name 'SoupURI' 1827 | SoupURI *puri = soup_uri_new(pagestr); | ^~~~~~~ ext.c:1841:17: error: unknown type name 'SoupURI' 1841 | SoupURI *ruri = soup_uri_new(reqstr); | ^~~~~~~ make: *** [makefile:22: ext.so] Error 1

Would it be of any interest in adding support for using libsoup3/webkit2gtk-4.1?
Or move over to 4.1, or support for both perhaps?
Any houghs on this?

@jun7
Copy link
Owner

jun7 commented Feb 8, 2022

Hi. Thank you for reporting.
I'm interest in adding support 4.1.
don't move to 4.1 though.

@hovercats
Copy link
Author

Awesome. That seems to have done the trick. Wyeb now buils fine. I havent been able to do much testing yet, but seems to work fine.
Closing the issue, and should there be any other issues Ill get back to you.
Cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants