modify outputs to use comm #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the outputs widget to use comm rather than calling ipython directly. This fixes jupyter-widgets#2953 and Calysto/metakernel#217
|
Thanks! Adding to the queue for review... |
martinRenou
reviewed
Feb 9, 2021
|
I resolved the conflict with master (this conflicted with #3199). This looks fine to me now. @martinRenou or @ibdafna (or anyone else) - can you review my changes? |
|
Will review in the morning! |
|
Itay, feel free to merge if you are comfortable with the code. |
|
Looks like the test failure was not relevant, and should be fixed in #3227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the outputs widget to use comm rather than calling
ipython directly. This fixes #2953 and Calysto/metakernel#217