Fix print preview in Firefox #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ah, cell are overflowing on the right... |
Author
|
Yes, sorry. I thought it was clear from the images. This has been happening for a while. By the way, the small width of the cells is not related to the grid, though. That is a bug in CodeMirror reported here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short, the print preview has been broken in Firefox for a while. In master:
We didn't notice because if you add enough cells, the bug doesn't occur.
When I was trying to reproduce this bug after the sticky header PR, I noticed that it was not Firefox that was causing the bug. It is the grid that is being applied in some media queries. However, it is easy to avoid that issue with
width: 100%;in the notebook container. After this simple fix the issue is resolved:@minrk If this was the main issue with the sticky header PR, you might want to give it a second look. I solved the performance issue a few weeks ago and the print preview was the only thing left to be fixed. This is the repository with the changes.