Skip to content

Conversation

takluyver
Copy link
Member

Closes ipython/ipython#8416

Should be backported to 3.2 as well, since we seem to be planning for another 3.x release.

@Carreau
Copy link
Member

Carreau commented May 8, 2015

+1

@rgbkrk
Copy link
Member

rgbkrk commented May 8, 2015

Yep, that makes sense.

@rgbkrk
Copy link
Member

rgbkrk commented May 8, 2015

The error is name change related, only 5 minutes before this PR was opened.

======================================================================
ERROR: test_list_formats (jupyter_notebook.services.nbconvert.tests.test_nbconvert_api.APITest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/jupyter/jupyter_notebook/jupyter_notebook/services/nbconvert/tests/test_nbconvert_api.py", line 27, in test_list_formats
    formats = self.nbconvert_api.list_formats().json()
  File "/home/travis/build/jupyter/jupyter_notebook/jupyter_notebook/services/nbconvert/tests/test_nbconvert_api.py", line 20, in list_formats
    return self._req('GET', '')
  File "/home/travis/build/jupyter/jupyter_notebook/jupyter_notebook/services/nbconvert/tests/test_nbconvert_api.py", line 16, in _req
    response.raise_for_status()
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/models.py", line 851, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
HTTPError: 500 Server Error: Internal Server Error
-------------------- >> begin captured logging << --------------------
NotebookApp: INFO: Shutting down kernels
root: DEBUG: Installing kernelspec in /tmp/tmpkAKO0V/.local/share/jupyter/kernels/python2
NotebookApp: INFO: Serving notebooks from local directory: /tmp/tmpegAI0t
NotebookApp: INFO: 0 active kernels 
NotebookApp: INFO: The IPython Notebook is running at: http://localhost:12341/
NotebookApp: INFO: Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): localhost
requests.packages.urllib3.connectionpool: DEBUG: "GET /api/contents HTTP/1.1" 200 214
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): localhost
NotebookApp: WARNING: Could not import nbconvert: No module named jupyter_nbconvert.exporters.export
requests.packages.urllib3.connectionpool: DEBUG: "GET /api/nbconvert HTTP/1.1" 500 109
NotebookApp: ERROR: {
  "Host": "localhost:12341", 
  "User-Agent": "python-requests/2.7.0 CPython/2.7.9 Linux/3.13.0-40-generic", 
  "Connection": "keep-alive", 
  "Accept": "*/*", 
  "Accept-Encoding": "gzip, deflate"
}
NotebookApp: ERROR: 500 GET /api/nbconvert (::1) 2.00ms referer=None

I think the namespace changed for jupyter_nbconvert to nbconvert in jupyter/nbconvert#18, only 30 minutes ago.

@rgbkrk
Copy link
Member

rgbkrk commented May 8, 2015

With new commit comes new merge commit testing!

@takluyver
Copy link
Member Author

It looks like #71 should have fixed all the references to nbconvert.

@takluyver
Copy link
Member Author

With new testing comes success.

Carreau added a commit that referenced this pull request May 8, 2015
Set contentType to JSON when sending session models
@Carreau Carreau merged commit 963637a into jupyter:master May 8, 2015
takluyver added a commit to takluyver/ipython that referenced this pull request May 8, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPython sends JSON HTTP POST with non-conforming content type application/x-www-form-urlencoded breaking WebOb HTTP proxying

3 participants